This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb ChangeLog breakpoint.c testsuite/Chang ...


CVSROOT:	/cvs/src
Module name:	src
Changes by:	brobecke@sourceware.org	2011-10-02 02:13:13

Modified files:
	gdb            : ChangeLog breakpoint.c 
	gdb/testsuite  : ChangeLog 
Added files:
	gdb/testsuite/gdb.base: save-bp.c save-bp.exp 

Log message:
	thread-specific breakpoints not saved properly by save-breakpoint
	
	Initially, I noticed that the save command was often missing
	new lines in the file that it generated.  For instance, consider:
	
	% gdb save-bp
	(gdb) b break_me
	(gdb) b save-bp.c:27
	(gdb) save breakpoints bps
	
	The contents of the bps file would be:
	
	% cat bps
	break break_mebreak save-bp.c:27
	
	Looking further into the problem, I realized that the missing newlines
	are just a consequence of a missing call to print_recreate_thread.
	After having generated the breakpoint location in the break command,
	we cannot put a new line until we have looked at whether we need to
	add a 'thread NUM' argument.
	
	gdb/ChangeLog:
	
	* breakpoint.c (bkpt_print_recreate): Add call to
	print_recreate_thread.
	
	gdb/testsuite/ChangeLog:
	
	* gdb.base/save-bp.exp, gdb.base/save-bp.c: New files.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.13367&r2=1.13368
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/breakpoint.c.diff?cvsroot=src&r1=1.614&r2=1.615
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.2868&r2=1.2869
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/save-bp.c.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/save-bp.exp.diff?cvsroot=src&r1=NONE&r2=1.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]