This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Additional files for .debug_macro support


On Tue, 2014-11-04 at 15:49 +0100, Petr Machata wrote:
> I forgot to add these files to the main .debug_macro support patch.  I
> present them separately here, as I think that will make review actually
> easier.  But do tell me otherwise.  I would of course squash them before
> pushing to master.

Looks fine. One nitpick.

> diff --git a/libdw/dwarf_macro_getsrcfiles.c b/libdw/dwarf_macro_getsrcfiles.c
> new file mode 100644
> index 0000000..2b8466b
> --- /dev/null
> +++ b/libdw/dwarf_macro_getsrcfiles.c
> @@ -0,0 +1,88 @@
> +/* Return a version of a macro.

Wrong comment for this file.

Thanks,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]