This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: 0.141
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 20 Apr 2009 13:42:18 +0200
- Subject: Re: 0.141
On Sun, 2009-04-19 at 20:58 -0700, Roland McGrath wrote:
> I think we are about ready to go for 0.141 (a605a3c). I say wait til first
> thing Monday to give Mark a chance to yell (should be plenty of time given
> 9 hours between us). If no new fires, tag it.
One small yell (on i386, x86_64 is fine):
gcc -D_GNU_SOURCE -DHAVE_CONFIG_H -I. -I/home/mark/src/elfutils/libdwfl -I.. -I. -I/home/mark/src/elfutils/libdwfl -I/home/mark/src/elfutils/libdwfl/../libelf -I/home/mark/src/elfutils/libdwfl/../libebl -I/home/mark/src/elfutils/libdwfl/../libdw -I.. -I/home/mark/src/elfutils/libdwfl/../lib -Wall -Werror -Wshadow -Wunused -Wformat=2 -Wextra -std=gnu99 -g -O2 -fstack-protector-all -D_FORTIFY_SOURCE=2 -MT dwfl_module_getdwarf.o -MD -MP -MF .deps/dwfl_module_getdwarf.Tpo -c -o dwfl_module_getdwarf.o /home/mark/src/elfutils/libdwfl/dwfl_module_getdwarf.c
/home/mark/src/elfutils/libdwfl/dwfl_module_getdwarf.c:124: error: conflicting types for ‘__libdwfl_getelf’
/home/mark/src/elfutils/libdwfl/libdwflP.h:245: error: previous declaration of ‘__libdwfl_getelf’ was here
Fixed by marking the implementation of __libdwfl_getelf also internal (attached).
No other issues building and reg-testing against systemtap.
Cheers,
Mark
diff --git a/libdwfl/dwfl_module_getdwarf.c b/libdwfl/dwfl_module_getdwarf.c
index 0441eb3..06cb491 100644
--- a/libdwfl/dwfl_module_getdwarf.c
+++ b/libdwfl/dwfl_module_getdwarf.c
@@ -121,6 +121,7 @@ open_elf (Dwfl_Module *mod, struct dwfl_file *file)
/* Find the main ELF file for this module and open libelf on it.
When we return success, MOD->main.elf and MOD->main.bias are set up. */
void
+internal_function
__libdwfl_getelf (Dwfl_Module *mod)
{
if (mod->main.elf != NULL /* Already done. */