This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH v2 1/3] libdw: Add an inlined fast path for __libdw_form_val_len
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 13 Dec 2013 15:19:47 +0100
- Subject: Re: [PATCH v2 1/3] libdw: Add an inlined fast path for __libdw_form_val_len
Josh Stone <jistone@redhat.com> writes:
> + /* Small lookup table of forms with fixed lengths. Absent indexes are
> + * initialized 0, so any truly desired 0 is set to 0x80 and masked. */
/* GNU coding style has comments that go
without continuation asterisks. */
Sorry, I didn't notice this before. Or maybe it wasn't there, I don't
know. The patch is fine otherwise, so it can be committed without
re-posting after this is corrected.
> + /* NB: This doesn't cover constant form lengths, which are
> + * already handled by the inlined __libdw_form_val_len. */
Here as well.
Thanks,
PM