This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch 4/4] unwinder: s390 and s390x
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 18 Dec 2013 18:30:53 +0100
- Subject: Re: [patch 4/4] unwinder: s390 and s390x
On Wed, 2013-12-18 at 18:12 +0100, Jan Kratochvil wrote:
> On Wed, 18 Dec 2013 18:10:16 +0100, Mark Wielaard wrote:
> > +2013-12-18 Mark Wielaard <mjw@redhat.com>
> > +
> > + * 390_initreg.c (s390_set_initial_registers_tid): Use union
> ^^ missing 's'
> [...]
> > + if (! setfunc (16, 16, dwarf_regs, arg))
> > + return false;
> > + dwarf_regs[0] = user_regs.regs.psw.addr;
>
> These are excessive 3 lines. They weren't there before.
Sigh. So sorry. That is what I get for thinking I could just copy/paste
a patch by hand instead of properly using git to transfer it between
machines.
Fixed,
Mark
>From 565149d564cfe9da3b5cd94c9387ee0473d0704a Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Wed, 18 Dec 2013 18:26:55 +0100
Subject: [PATCH] Fix s390_initreg.c patch copy/paste error.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
backends/ChangeLog | 2 +-
backends/s390_initreg.c | 3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/backends/ChangeLog b/backends/ChangeLog
index 23329d0..4535789 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,6 +1,6 @@
2013-12-18 Mark Wielaard <mjw@redhat.com>
- * 390_initreg.c (s390_set_initial_registers_tid): Use union
+ * s390_initreg.c (s390_set_initial_registers_tid): Use union
to avoid type-punning when assigning a double to a Dwarf_Word.
2013-12-18 Jan Kratochvil <jan.kratochvil@redhat.com>
diff --git a/backends/s390_initreg.c b/backends/s390_initreg.c
index 8fc54bc..b4c4b67 100644
--- a/backends/s390_initreg.c
+++ b/backends/s390_initreg.c
@@ -77,9 +77,6 @@ s390_set_initial_registers_tid (pid_t tid __attribute__ ((unused)),
} fpr = { .d = user_regs.regs.fp_regs.fprs[u] };
dwarf_regs[u] = fpr.w;
}
- if (! setfunc (16, 16, dwarf_regs, arg))
- return false;
- dwarf_regs[0] = user_regs.regs.psw.addr;
if (! setfunc (16, 16, dwarf_regs, arg))
return false;
--
1.7.1