This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Test case for handling archives with 64-bit symbol table


On Wed, 2012-08-01 at 21:41 +0200, Petr Machata wrote:
> Signed-off-by: Petr Machata <pmachata@redhat.com>
> ---
>  tests/ChangeLog             |    7 +++++++
>  tests/Makefile.am           |    6 ++++--
>  tests/archive64.a.bz2       |  Bin 0 -> 834 bytes
>  tests/run-test-archive64.sh |   43 +++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 54 insertions(+), 2 deletions(-)
>  create mode 100644 tests/archive64.a.bz2
>  create mode 100755 tests/run-test-archive64.sh
> 
> diff --git a/tests/ChangeLog b/tests/ChangeLog
> index 6133048..cde71f4 100644
> --- a/tests/ChangeLog
> +++ b/tests/ChangeLog
> @@ -1,3 +1,10 @@
> +2012-08-01  Petr Machata  <pmachata@redhat.com>
> +
> +	* test-archive64.sh: New test.
> +	* archive64.a.bz2: New testfile.
> +	* Makefile.am (TESTS): Add test-archive64.sh.
> +	(EXTRA_DIST): Likewise.

test-archive64.sh here should be run-test-archive64.sh.
And if I may bother you with one other file rename (sorry), could you
rename archive64.a.bz2 to testarchive64.a.bz2. That would make things a
bit more consistent in the test directory.

Looks fine otherwise.

Thanks,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]