This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: elf*_xlatetom: do not check ELF_T_NHDR has integer number of records
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 19 Jul 2012 13:22:11 +0200
- Subject: Re: elf*_xlatetom: do not check ELF_T_NHDR has integer number of records
On Tue, 2012-07-17 at 21:22 +0200, Mark Wielaard wrote:
> I added a testcase for the issue that triggers on x86.
>
> commit 97212fef830f9f193d4a43ee45338622db40b19c
> Author: Mark Wielaard <mjw@redhat.com>
> Date: Tue Jul 17 21:12:39 2012 +0200
>
> Add ppc testcase for elf32_xlatetom.c fix.
>
> Fails before commit bc0f74 on x86, succeeds after.
>
> Signed-off-by: Mark Wielaard <mjw@redhat.com>
Oops, I was a little too quick. Forgot to add the new testfile to
EXTRA_DIST and to cleanup after the test. Luckily make distcheck caught
my mistake. Fixed as attached.
commit 714ea0ec612225e1d5bed6ef0ea7bb8c135ae4c4
Author: Mark Wielaard <mjw@redhat.com>
Date: Thu Jul 19 13:07:39 2012 +0200
test_cleanup run-unstrip-n.sh and add testcore-rtlib-ppc.bz2 to EXTRA_DIST.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 63ca9b7..cc0f243 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,8 @@
+2012-07-19 Mark Wielaard <mjw@redhat.com>
+
+ * run-unstrip-n.sh: test_cleanup.
+ * Makefile.am (EXTRA_DIST): Add testcore-rtlib-ppc.bz2.
+
2012-07-11 Mark Wielaard <mjw@redhat.com>
* run-readelf-macro.sh: New test.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index bffa571..fcbabf0 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -161,7 +161,7 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh \
run-readelf-d.sh testlib_dynseg.so.bz2 \
run-readelf-gdb_index.sh testfilegdbindex5.bz2 \
testfilegdbindex7.bz2 \
- run-unstrip-n.sh testcore-rtlib.bz2 \
+ run-unstrip-n.sh testcore-rtlib.bz2 testcore-rtlib-ppc.bz2 \
run-low_high_pc.sh testfile_low_high_pc.bz2 \
run-macro-test.sh testfile-macinfo.bz2 testfile-macros.bz2
diff --git a/tests/run-unstrip-n.sh b/tests/run-unstrip-n.sh
index a2f0d6c..1353b1d 100755
--- a/tests/run-unstrip-n.sh
+++ b/tests/run-unstrip-n.sh
@@ -51,4 +51,6 @@ testrun_compare ../src/unstrip -n --core=testcore-rtlib-ppc <<\EOF
0xffb0000+0x50000 edec437a85026a1cf8cda94003706202733130c1(a)0xffb0124 /lib/ld.so.1 - ld.so.1
EOF
+test_cleanup
+
exit 0