This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libdwfl: Report core module segment even when NT_FILE build-id doesn't match.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 08 Jun 2015 11:21:41 +0200
- Subject: Re: [PATCH] libdwfl: Report core module segment even when NT_FILE build-id doesn't match.
On Sun, 2015-06-07 at 13:54 +0200, Jan Kratochvil wrote:
> On Sat, 06 Jun 2015 16:00:08 +0200, Mark Wielaard wrote:
> > dwfl_segment_report_module can take the NT_FILE note contents to find
> > the matching file for the module on the file system from the core file.
> > If the file exists but the build-id didn't match we would not report the
> > module. But we should just report the module anyway, ignore the file,
> > and try to match the ELF image another way.
>
> Yes, I agree. After the patch elfutils will still not use an ELF file with
> non-matching build-id.
Thanks and yes, it will still check the build-id.
Pushed to master.
Cheers,
Mark