This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH v2 3/3] dwarf_begin, dwarf_begin_elf: DWARF_C_FLAG_NO_DEBUGALTLINK command flag
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 10 Apr 2014 20:16:48 +0200
- Subject: Re: [PATCH v2 3/3] dwarf_begin, dwarf_begin_elf: DWARF_C_FLAG_NO_DEBUGALTLINK command flag
On Thu, 2014-04-10 at 13:08 +0200, Florian Weimer wrote:
> + * libdw.h (enum Dwarf_Cmd): New member
> + DWARF_C_FLAG_NO_DEBUGALTLINK.
> + * libdwP.h (DWARF_C_FLAG_MASK): New macro.
> + * dwarf_begin_elf.c (check_section): Move call to to
> + open_debugaltlink to ...
> + (dwarf_begin_elf): here. Mask command flags and handle
> + DWARF_C_FLAG_NO_DEBUGALTLINK.
> + * dwarf_begin.c (dwarf_begin): Mask command flags.
I don't really like this. This assumes we keep the magic opening of the
altfile in dw. But I think we should just drop it eventually and move
any magic to the dwfl side. When we provide dwarf_setalt() then users
should just explicitly always use that IMHO.
Cheers,
Mark