This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libelf: Drop internal_function from __libelf_set_data_list_rdlock.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 19 Feb 2015 22:22:12 +0100
- Subject: Re: [PATCH] libelf: Drop internal_function from __libelf_set_data_list_rdlock.
On Thu, 2015-02-19 at 15:37 +0300, Alexander Cherepanov wrote:
> On 2015-02-18 22:57, Mark Wielaard wrote:
> > On Tue, 2015-02-17 at 21:00 +0300, Alexander Cherepanov wrote:
> >> Have to use this patch when building 32-bit version of elfutils for the
> >> latest round of fuzzing.
> >
> > Sorry about that. It was introduced by my commit b543cd "libelf: Fix
> > elf_newdata when raw ELF file/image data is available".
> >
> > I see there is more stuff broken on i686. Also introduced by me. Sigh.
>
> Another problem I met with 32-bit build is that nm lost its -C option
> (and there is /* #undef USE_DEMANGLE */ in config.h).
demangling support depends on the standard c++ demangler. Does
config.log say you have __cxa_demangle in -lstdc++ ?
> > So instead of dropping it in the implementation, I think we should add
> > it in the definition.
> >
> > Does the attach solve your issue?
>
> Yes, it works fine, thanks!
Thanks for checking. Pushed to master.
Cheers,
Mark