This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
[PATCH 1/5] addr2line: Split options in input and output format groups.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 20 May 2015 16:35:43 +0200
- Subject: [PATCH 1/5] addr2line: Split options in input and output format groups.
This makes it clear that -j, --section=NAME is about how input is treated,
not how the output is formatted.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
src/ChangeLog | 5 +++++
src/addr2line.c | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index 02f6584..f4ff1fb 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-20 Mark Wielaard <mjw@redhat.com>
+
+ * addr2line (argp_option): Group 'section' under "Input format
+ options".
+
2015-05-12 Mark Wielaard <mjw@redhat.com>
* strip.c (debug_fd): New static variable.
diff --git a/src/addr2line.c b/src/addr2line.c
index 281a91e..c7ff7f7 100644
--- a/src/addr2line.c
+++ b/src/addr2line.c
@@ -54,7 +54,11 @@ ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT;
/* Definitions of arguments for argp functions. */
static const struct argp_option options[] =
{
- { NULL, 0, NULL, 0, N_("Output selection options:"), 2 },
+ { NULL, 0, NULL, 0, N_("Input format options:"), 2 },
+ { "section", 'j', "NAME", 0,
+ N_("Treat addresses as offsets relative to NAME section."), 0 },
+
+ { NULL, 0, NULL, 0, N_("Output format options:"), 3 },
{ "basenames", 's', NULL, 0, N_("Show only base names of source files"), 0 },
{ "absolute", 'A', NULL, 0,
N_("Show absolute file names using compilation directory"), 0 },
@@ -62,8 +66,6 @@ static const struct argp_option options[] =
{ "symbols", 'S', NULL, 0, N_("Also show symbol or section names"), 0 },
{ "symbols-sections", 'x', NULL, 0, N_("Also show symbol and the section names"), 0 },
{ "flags", 'F', NULL, 0, N_("Also show line table flags"), 0 },
- { "section", 'j', "NAME", 0,
- N_("Treat addresses as offsets relative to NAME section."), 0 },
{ "inlines", 'i', NULL, 0,
N_("Show all source locations that caused inline expansion of subroutines at the address."),
0 },
--
1.8.3.1