This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Add support for Tilera TILE-Gx processor.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 22 Aug 2012 09:22:13 -0700
- Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor.
> + /* Can't happen */
Period and two spaces at the end of a sentence.
> + default:
> + *setname = NULL;
> + return 0;
Bad indentation.
> --- a/libebl/ChangeLog
> +++ b/libebl/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21 Jeff Kenton <jkenton@tilera.com>
> +
> + * eblopenbackend.c (machines): Add tilegx.
> +
> +
> 2011-06-26 Mark Wielaard <mjw@redhat.com>
One excess blank line there.
> --- a/src/ChangeLog
> +++ b/src/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21 Jeff Kenton <jkenton@tilera.com>
> +
> + * elflint.c (valid_e_machine): Add EM_TILEGX and EM_TILEPRO.
> +
> +
> 2012-08-16 Mark Wielaard <mjw@redhat.com>
Same here.
Looks fine to me other than those nits.
Thanks,
Roland