This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for Tilera TILE-Gx processor.


> +    /* Can't happen */

Period and two spaces at the end of a sentence.

> +    default:
> +        *setname = NULL;
> +        return 0;

Bad indentation.

> --- a/libebl/ChangeLog
> +++ b/libebl/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21  Jeff Kenton  <jkenton@tilera.com>
> +
> +	* eblopenbackend.c (machines): Add tilegx.
> +
> +
>  2011-06-26  Mark Wielaard  <mjw@redhat.com>

One excess blank line there.

> --- a/src/ChangeLog
> +++ b/src/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21  Jeff Kenton  <jkenton@tilera.com>
> +
> +	* elflint.c (valid_e_machine): Add EM_TILEGX and EM_TILEPRO.
> +
> +
>  2012-08-16  Mark Wielaard  <mjw@redhat.com>

Same here.


Looks fine to me other than those nits.


Thanks,
Roland

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]