This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Fix bpf disassembler for _FORTIFY_SOURCE
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 11 Aug 2016 02:37:10 +0200
- Subject: Re: [PATCH] Fix bpf disassembler for _FORTIFY_SOURCE
On Wed, Aug 10, 2016 at 12:41:21PM +0530, Richard Henderson wrote:
> It's illegal to skip positional operands for printf. Rearrange the
> printing of the instructions to use exactly the operands required.
>
> Also, fix printing of mod operations: s/%/%%/ in the print format.
> Also, fix printing of endian operations: remove extra spaces.
Looks good and does fix the FORTIFY_SOURCE issue (plus fixing those
misprinted operations). Comitted and pused to master with the
following ChangeLog entries:
libcpu/ChangeLog:
2016-08-10 Richard Henderson <rth@redhat.com>
* bpf_disasm.c (bpf_disasm): Rearrange the printing of instructions
to use exactly the operands required.
tests/ChangeLog:
2016-08-10 Richard Henderson <rth@redhat.com>
* file-bpf-dis1.expect.bz2: Fix expected mod and endian operations
output.
Thanks,
Mark