This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 2/2] tests: ensure backtrace.c exec_dump sets jmp
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 12 Feb 2015 00:32:10 +0100
- Subject: Re: [PATCH 2/2] tests: ensure backtrace.c exec_dump sets jmp
Josh Stone <jistone@redhat.com> writes:
> With CFLAGS='-Og -g', F21 gcc hits -Werror=maybe-uninitialized on jmp in
> the call "prepare_thread (pid2, jmp)". It's fine with -O2/-O0.
>
> The only way this could be unset is if the loop before ran to
> completion, and there's already an assert against this case.
GCC is sort of right in that that assert could in theory be a nop. It's
not appropirate in the first place, for handling what amounts to user
input, but this is a test case, so who cares.
Looks good to me.
Thanks,
Petr