This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch 3/4] Provide elf_scnfindvma
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 13 Nov 2013 13:03:21 +0100
- Subject: Re: [patch 3/4] Provide elf_scnfindvma
On Wed, 2013-11-06 at 22:10 +0100, Jan Kratochvil wrote:
> Provide elf_scnfindvma
>
> libdwfl/
> 2013-11-06 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Provide elf_scnfindvma.
> * dwfl_module_addrsym.c (dwfl_module_addrsym) (same_section): Call
> elf_scnfindvma where is the code from here moved out.
>
> libelf/
> 2013-11-06 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Provide elf_scnfindvma.
> * Makefile.am (libelf_a_SOURCES): Add elf_scnfindvma.c.
> * elf_scnfindvma.c: New file.
> * libelf.h (elf_scnfindvma): New declaration.
> * libelf.map (ELFUTILS_1.156): New with elf_scnfindvma.
Although the code itself looks fine it should not be added to libelf.
Please just make this an internal libdwfl function if you want to reuse
it. Or just duplicate the code if not easily shared, it is small enough.
There are other implementation of libelf and gelf and we should try to
keep them somewhat compatible. There are some small differences already,
but lets not make them bigger.
Thanks,
Mark