This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libelf: use the right size when preading in[0].sh_size


On Tue, Oct 20, 2015 at 04:22:08PM +0200, Jose E. Marchesi wrote:
> 
> This fixes a small thinko, that was making get_shnum to return
> (size_t) -1 for all elf-64 files with e_shnum == 0.

Thanks applied.

I was wondering why we didn't notice before, but that is probably because
this only happens when the file really has zero sections, wasn't mmapped
and had different endianness on a platform that doesn't allow unaligned
access. So a combination of things that is unlikely to occur on some
popular architectures.

Cheers,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]