This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libdw: Read DW_AT_decl_file/line/column as unsigned
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 06 Feb 2014 14:08:22 +0100
- Subject: Re: [PATCH] libdw: Read DW_AT_decl_file/line/column as unsigned
On Wed, 2014-02-05 at 12:02 -0800, Josh Stone wrote:
> On 02/05/2014 11:58 AM, Josh Stone wrote:
> > Also, an assertion on the range of line/column is now a handled error,
> > setting DWARF_E_INVALID_DWARF for values greater than INT_MAX.
>
> Note, this is not so much INVALID as UNSUPPORTED, really, as the current
> API can only deal with int values.
2^31-1 should be enough for anybody :) There is probably really
something wrong when the DWARF indicates you have more than so many
source lines in a file. I think INVALID is correct in this case.
> I still think an assert was the wrong way to handle this
Agreed.
Cheers,
Mark