This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch] Fix elf_getdata_rawchunk false error
- From: Roland McGrath <roland at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 10 Jan 2011 22:02:53 -0800
- Subject: Re: [patch] Fix elf_getdata_rawchunk false error
> On Tue, 04 Jan 2011 19:03:20 +0100, Roland McGrath wrote:
> > > OK to merge to master? It is now in <jankratochvil/pending>.
> >
> > Yes, that looks fine.
>
> Checked in:
> f1ccc410d6bda15ed49fc5d0fef9f6f65acbfb63
Thanks.
> off_t and loff_t should be always the same due to AC_SYS_LARGEFILE in use.
> Therefore also unifying s/(off_t|loff_t)/loff_t/ as at least in public elfutils
> headers apps using elfutils-libs may not be using AC_SYS_LARGEFILE.
Right. The only appearances of *off_t in the public API are in libelf.h,
and those are already loff_t because of exactly this issue. But it would
indeed be clearer to use loff_t uniformly in all the source even though
off_t always means the same thing in the internal code because we compile
it with -D_FILE_OFFSET_BITS=64.
Thanks,
Roland