This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 6/6] Provide assert_perror when it's not defined
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 04 May 2015 16:22:25 +0200
- Subject: Re: [PATCH 6/6] Provide assert_perror when it's not defined
On Mon, May 04, 2015 at 07:53:27AM +0200, Petr Machata wrote:
> Max Filippov <jcmvbkbc@gmail.com> writes:
>
> > assert_perror is a GNU extension and is not provided by uClibc. Provide
> > definition when that macro is not available.
>
> It looks like it would pay off to have a dedicated header file for this
> macro.
Yes, but it is only needed in the backtrace tests. So please make it a
tests only header. But since this is in the tests a simple assert (errno)
would IMHO also be fine. It is just there to make sure the tests fail on
something unexpected. For real code we should do proper error checking.
Cheers,
Mark