This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Add support for Tilera TILE-Gx processor.
- From: Jeff Kenton <jkenton at tilera dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 17 Aug 2012 09:28:10 -0400
- Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor.
On 08/16/2012 01:49 PM, Roland McGrath wrote:
> We don't touch elf.h directly, we only copy it verbatim from glibc.
> I've done that update.
>
> Your changes need ChangeLog entries.
>
> You don't need to quote the contribution agreement in your commit message,
> just the -s (Signed-off-by line) is enough.
>
> Your new files have the wrong copyright terms.
> Please follow the model of the existing files in the git repository.
>
> Please cite 'make check' results on a native build.
> You also need to add tilegx cases to run-allregs.sh and perhaps others.
Explain? What ties the "testfiles" to different processors? Names? Or
other magic?
> In backends/*_regs.c note how we have mostly avoided tables of string
> pointers, because these necessitate dynamic relocs for the pointers.
> That's not a problem with string constants used directly in code.
>
>
> Thanks,
> Roland