This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libdwfl: proc_maps_report should not fclose the given file.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 18 Sep 2013 16:13:40 +0200
- Subject: Re: [PATCH] libdwfl: proc_maps_report should not fclose the given file.
On Thu, 2013-09-12 at 15:47 +0200, Mark Wielaard wrote:
> Calling fclose only on bad_report, but not on other errors or success
> is confusing. The caller is always responsible for calling fclose on
> the given file. Otherwise flcose might be called twice (e.g. in
> dwfl_linux_proc_report).
I pushed this to master.