This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 3/5] tests: Add run-readelf-unknown-self.sh test to check for unknown DWARF codes.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 16 Aug 2012 16:34:09 -0700
- Subject: Re: [PATCH 3/5] tests: Add run-readelf-unknown-self.sh test to check for unknown DWARF codes.
> --- a/tests/ChangeLog
> +++ b/tests/ChangeLog
> @@ -1,5 +1,11 @@
> 2012-08-16 Mark Wielaard <mjw@redhat.com>
>
> + * run-readelf-unknown-self.sh: New test.
> + * Makefile.am (TESTS): Add run-readelf-unknown-self.sh.
> + (EXTRA_DIST): Likewise.
> +
> +2012-08-16 Mark Wielaard <mjw@redhat.com>
> +
> * allregs.c (dwarf_encoding_string): Removed.
> * show-die-info.c (dwarf_tag_string): Removed.
> (dwarf_attr_string): Removed.
No redundant header lines when the previous top change has the same header.
> +# Make sure there are no unknown DWARF codes.
> +testrun_on_self_nomatch "\?\?\? \([x0-9]+\)|lo_user\+0x[0-9a-f]+" ../src/readelf -N -w
This is still "" and should be ''.
> + for file in $self_test_files; do
> + testrun "$@" $file > self_matches.in
This should fail the test if testrun (i.e. readelf) exits nonzero.
> + exit_status=1;
Still superfluous ; here.
Did you resend the old version of the patch instead of a new one?
Thanks,
Roland