This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] addr2line: Remove newline from strings returned by getline.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 19 Aug 2013 11:43:17 +0200
- Subject: Re: [PATCH] addr2line: Remove newline from strings returned by getline.
On Mon, 2013-08-12 at 14:49 +0200, Mark Wielaard wrote:
> getline can return strings with a newline as last character when reading
> from stdin. This could cause confusing symbol lookup failures like:
> addr2line: cannot find symbol 'foo
> '
> So if the last character of the buf returned by getline is a newline just
> null-terminate it right there. Also add a new testcase run-addr2line-test.sh.
I pushed this to master now.
Cheers,
Mark