This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

readelf.c: ‘u128’ may be used uninitialized in this function


Got another build failure (rhel6 beta x86_64 this time):

gcc -D_GNU_SOURCE -DHAVE_CONFIG_H
-DLOCALEDIR='"/usr/local/install/elfutils/share/locale"'  -DDEBUGPRED=0
-DSRCDIR=\"/home/mark/src/elfutils/src\" -DOBJDIR=
\"/usr/local/build/elfutils-obj/src\" -I. -I/home/mark/src/elfutils/src
-I.. -I. -I/home/mark/src/elfutils/src -I/home/mark/src/elfutils/lib
-I.. -I/home/mark/src/elfutils/src/../libelf
-I/home/mark/src/elfutils/src/../libebl
-I/home/mark/src/elfutils/src/../libdw
-I/home/mark/src/elfutils/src/../libdwfl
-I/home/mark/src/elfutils/src/../libasm   -std=gnu99 -Wall -Wshadow
-Werror -Wunused -Wextra -Wformat=2   -g -O2 -MT readelf.o -MD -MP
-MF .deps/readelf.Tpo -c -o
readelf.o /home/mark/src/elfutils/src/readelf.c
cc1: warnings being treated as errors
/home/mark/src/elfutils/src/readelf.c: In function
‘print_debug_line_section’:
/home/mark/src/elfutils/src/readelf.c:5800: error: ‘u128’ may be used
uninitialized in this function

I think the compiler is right and this should be fixed by:

diff --git a/src/readelf.c b/src/readelf.c
index 08b85ab..dbc8499 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -6029,6 +6029,7 @@ advance address by fixed value %u to %s\n"),
                  if (unlikely (standard_opcode_lengths[opcode] != 1))
                    goto invalid_unit;
 
+                 get_uleb128 (u128, linep);
                  printf (gettext (" set isa to %u\n"), u128);
                  break;
                }



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]