This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: eu-unstrip -n fails to process a coredump


11.11.2009 16:37, Petr Machata wrote:
> 05.11.2009 16:41, Petr Machata wrote:
> But I think there is a bug in libdwfl, the library shouldn't find zeroes
> there.

The bug is in read-ahead logic of dwfl_elf_phdr_memory_callback.  It 
reads ahead as much of offset-contiguous data as it can, but doesn't 
take into account whether the data is vaddr-contiguous too. 
report_r_debug assumes it is.

My fix is sitting on HEAD of pmachata/dwfl_core_file_report branch, I've 
reverted my earlier fix and merged in master.

I think that your fix (ignoring zero entries and not bailing out on 
dwfl_addrsegment failure) is orthogonal to mine, each addresses 
different bug.

PM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]