This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH v2] Add fallthrough attributes
- From: Ulf Hermann <ulf dot hermann at qt dot io>
- To: elfutils-devel at sourceware dot org, jpewhacker at gmail dot com
- Date: Fri, 9 Feb 2018 10:08:09 +0100
- Subject: Re: [PATCH v2] Add fallthrough attributes
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=ulf dot hermann at qt dot io;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=axyLevoOvqIClIyX+FJ6HQ8uneftst2r/eOXpv/Leqg=; b=dtPJP58t+pWEZygaPBxwCGeQFppHepFMQim8ecNHMBe9w+BkbIHrxgP2+CFBwdec0XUqG1juaV9ER+zrYD0SOdWqcyseN+jA+Wj4LXl4w9Sqp0/7To0+PWF3cP2ITG0yx/kvS/DPQt+hv4P23mrx6HmJ1NlXFTS4VzJZAkFsx38=
- References: <20180208225646.12036-1-JPEWhacker@gmail.com> <20180208233010.11395-1-JPEWhacker@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> [...]
> +#ifdef HAVE_FALLTHROUGH
> + __attribute__ ((fallthrough));
> +#endif
> [...]
I would like to see this stanza wrapped in a macro, so that we only have one "#ifdef HAVE_FALLTHROUGH" in the code, not another one in every place we want to fall through. See the "internal_function" macro defined in lib/eu-config.h for a similar case.
Ulf