Re: [PATCH] Don't look for kernel version if not running on linux

[Mark Wielaard <mark at klomp dot org>]

On Tue, May 02, 2017 at 12:17:24PM +0200, Ulf Hermann wrote:
> > You can get uname() on Windows through gnulib, but at the cost at
> > linking to additional windows DLLs. It calls gethostname and for that
> > we need to link against ws2_32.dll. That's an unreasonable dependency
> > for getting something we cannot use anyway. I suggest we just set
> > errno to ENOTSUP then.
> 
> I should clarify this a bit. We only use uname() to obtain the kernel
> version and we only use the kernel version to search for directories
> containing kernel modules. The only operating system where this makes sense
> is linux as we cannot handle anything but linux kernel modules there.
> Therefore there is no point in retrieving the kernel version on any other
> OS.

Agreed. So committed as attached.

Thanks,

Mark

Attachment: 0001-Don-t-look-for-kernel-version-if-not-running-on-linu.patch
Description: Text document