This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message
- From: "Ilija Kocho [ÐÐÐÑÐ ÐÐÑÐ]" <ilijak at siva dot com dot mk>
- To: Michael Jones <mjones at linear dot com>, Lambrecht JÃrgen <J dot Lambrecht at TELEVIC dot com>
- Cc: "ecos-patches at ecos dot sourceware dot org" <ecos-patches at ecos dot sourceware dot org>
- Date: Sat, 15 Feb 2014 01:03:11 +0100
- Subject: Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message
- Authentication-results: sourceware.org; auth=none
- References: <52FB723E dot 2080900 at televic dot com> <45BF36F1-2D74-464D-AAC6-D69F5D7D663B at linear dot com>
On 12.02.2014 15:32, Michael Jones wrote:
> Jurgen,
>
> I typically put these in bugzilla with an explanation. That is where people look for patches before they are part of the source tree. As far as I can tell, it is the only way patches become part of the code base.
Indeed, Bugzilla is the preferred place for patch submission. Besides
discussion/collaboration forum, Bugzilla provides searchable database.
Patches and contributions is still available for but is depreciated.
Ref: http://ecos.sourceware.org/ecos/intouch.html . eCos Bugzilla shall
also forward the bug to patches mailing list if you select /Patches and
contributions/ component.
Ilija
> Mike
>
> On Feb 12, 2014, at 6:08 AM, Lambrecht JÃrgen <J.Lambrecht@TELEVIC.com> wrote:
>
>> Hi,
>>
>> I found a bug and fixed it, so I don't know if I need to use bugzilla
>> for that?
>> In attach the patch.
>>
>> file: net/common/current/src/dhcp_prot.c
>>
>> According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The
>> DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
>> So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same
>> transaction ID should be used ('xid' in C code).
>> We never had problems with that, but now we have a strict customer..
>>
>> Kind regards,
>> JÃrgen
>>
>> --
>> JÃrgen Lambrecht
>> R&D Associate
>> Mobile: +32 499 644 531
>> Tel: +32 (0)51 303045 Fax: +32 (0)51 310670
>> http://www.televic-rail.com
>> Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
>> Company number 0825.539.581 - RPR Kortrijk
>>
>> <dhcp_prot.patch>