[Bug 1001561] Internal flash driver for Freescale TWR-K60N512 board

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001561

--- Comment #40 from Ilija Kocho <ilijak@siva.com.mk> 2012-07-20 12:25:31 BST ---
Hi Nicolas

Thank you for the update.

(In reply to comment #39)
> (In reply to comment #38)
> > Created an attachment (id=1832)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1832) [details]
[details]
> > Hal part of the patch
> 
> Hello Ilija and Jifl,
> 
> I updated the two patches with some modifications (but not all) :
>  * I think I have made pretty much all the list of Jifl.
>  * I have made the modifications for the first point of Ilija  (regarding flash
> performance). For this feature, I had to create a flash_read function.
> Otherwise, the flash was read without calling the kinetis flash driver and
> therefore without the optimisation disabled, causing errors. Don't know if this
> is the right way to do it but it works like that.

It is actually a FMC _feature_ and there is a request that all writings in FMC
registers be done by code _not_ executing in flash. Ref: a note in: / 27.4(K60)
or 29.4(K70) Memory map and register descriptions /.

I would replace "optimization" with "acceleration". "Optimization" may be
associated with code optimizations - by compiler or handicraft while
"acceleration" is widely used for hardware that speeds up execution of flashed
code. Although FS doesn't use the term flash accelerator in their manuals
Cortex-M users should be familiar (NXP, ST). If you lack a time for new patches
I can do the changes.

> 
> So there is still work to do on Ilija's point 2 and 3.

Having in mind Jifl's comments probably point 2 can be put in TODO status. 3
too.

> 
> As I told to Ilija, I will not be working in my current company anymore so I
> will not be able to work on this project. 
> Nonetheless, others will work on this (notably Pierre-Jean Coudert, whom you 
> already spock with) and will ask for a copyright assignment if they need to.

To be on a safe side, copyright assignment, especially employer's disclaimer,
is recommended even for small patches and mandatory for substantial.

Should you contribute in eCos from your new job, we shall need a disclaimer
from your new employer.

Once again, thank you for contributing to eCos and I wish you fun and success
at your new job.

Live long and prosper.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.