This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001219] Ethernet driver for STM32 connectivity line with port on MMstm32f107 board.


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219

--- Comment #34 from Jerzy Dyrda <jerzdy@gmail.com> 2012-01-07 00:02:10 GMT ---
Hello Ilija,

(In reply to comment #29)
> (From update of attachment 1475 [details])
> Thank you for the update Jerzy.
> 
> Now we need little finish:
> 
> Missing ChangeLog entries for Variant and SPI remapping patches. Please add.
> 
> Copyright banners for driver and platform probably go too far in the past. I
> take it that this is essentially new code (especially the driver) and copyright
> message should reflect the fact.
> 
> And little clean up. There is a little trailing whitespace and some macros in
> Variant have trailing semicolons ";" (look arround line 415). I guess they
> shouldn't be.
All above done.

Thank you for your patient during code cleaning.

Best regards,
jerzy

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]