[Bug 1001291] New HAL for Cortex-M3 Smartfusion device

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001291

--- Comment #27 from Ilija Kocho <ilijak@siva.com.mk> 2011-12-03 15:47:39 GMT ---
Chhristophe

Thank you for the updates. I tried configuration with default template
(Ethernet driver diff not patched yet).

jifl, have we interpretation from FSF regarding STM disclaimer exception on
networking stacks?

As expected configtool raises warning for missing Ethernet driver, otherwise
creation of build tree proceedes without problem.

However building process raises following warnings (default tpl no changes):

.../spi_a2fxxx.c:466: warning: âa2fxxx_transaction_beginâ defined but not used
.../spi_a2fxxx.c:554: warning: âa2fxxx_transaction_transferâ defined but not
used
.../spi_a2fxxx.c:568: warning: âa2fxxx_transaction_tickâ defined but not used
.../spi_a2fxxx.c:583: warning: âa2fxxx_transaction_endâ defined but not used
.../spi_a2fxxx.c:608: warning: âa2fxxx_get_configâ defined but not used
.../spi_a2fxxx.c:614: warning: âa2fxxx_set_configâ defined but not used
.../spi_a2fxxx.c:218: warning: âa2fxxx_spi_bus_setupâ defined but not used

As expected warnings disappear when a spi bus is enabled, I guess you know what
to do.

Reading spi_a2fxxx.c I have also noticed that you are using \ for extension of
normal (non macro) lines. I would ask you to remove them since some editors
(such as MicroEmacs put warning on such lines.
Also some lines are much longer than famous 78 char boundary (example line 386)
I would ask you to also check other files for similar issues.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.