[Bug 1001116] Instruct lwIP to use special section for buffers and heap.

[bugzilla-daemon at bugs dot ecos dot sourceware dot org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116

--- Comment #13 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-29 14:54:09 GMT ---
Hi

So far it is about the below,

(In reply to comment #12)
> (In reply to comment #11)

[snip]

> > ... that can be
> > 
> > cdl_package CYGPKG_NET_LWIP {
> >     ...
> >     cdl_option CYGSEM_LWIP_MEM_SECTION {
> >         display     "Relocate memory pools"
> >         flavor      bool
> >         calculated  is_active(CYGDAT_LWIP_MEM_SECTION_NAME)
> >         ...
> >     }
> > }
> > 
> 
> Wouldn't it be clearer in configtool if CYGSEM_LWIP_MEM_SECTION is "grayed"
> when we have no memory section provided?
> Hence active_if CYGDAT_LWIP_MEM_SECTION_NAME

Agreed. I vote for a full control and no mess (gray for the most cases):

    cdl_option CYGSEM_LWIP_MEM_SECTION {
        ...
        flavor        bool
        default_value 0
        active_if     CYGDAT_LWIP_MEM_SECTION_NAME
        ...
    }

No calculate, no guess, the last word for a user! Even if her/his target
provides *_SECTION_NAME, he/she should decide use the feature or not.

[snip]

> Also there is one point for further discussion: 
>   - Concatenation or plain strings?

I prefer the plain strings.

> IMO it would depend on resolution for section related macros proposed in
> http://bugs.ecos.sourceware.org/attachment.cgi?id=1088 to Bug 1001114 . 
> 
> For reference, here is a digest of all code snippets as are in my current
> build:

> -----------------
> cdl_package CYGPKG_NET_LWIP {
>       ...
>         cdl_option CYGDAT_LWIP_MEM_SECTION {
>             display "Special memory section for lwIP buffers."
>             active_if CYGDAT_LWIP_MEM_SECTION_NAME
>             requires CYGDAT_LWIP_MEM_SECTION_NAME
>             flavor data
>             calculated { "\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\"" }
>             description "..."
>         }
>       ...
> }

I dislike the above as the most users will be to see in CT a strange grayed
data box like below:

- |__) Momory options
       [ab] "Special memory section for lwIP buffers."    | ".0"

What's that ".0"? That's concatenation with an absent data.

Be continue.

Thanks,
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.