This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: PHY update
- From: John Dallaway <john at dallaway dot org dot uk>
- To: Christophe Coutand <ccoutand at stmi dot com>
- Cc: Sachin Sushil Chaddha <schaddha at stmi dot com>, Edgar Grimberg <edgar dot grimberg at zylin dot com>, ecos-patches at ecos dot sourceware dot org, chadhas at ymail dot com
- Date: Wed, 09 Jun 2010 17:44:44 +0100
- Subject: Re: PHY update
- References: <D6050C555CC56940A7AF32652283027602C8B980@mail2.STMIRV01.COM> <4BEA8135.6040402@dallaway.org.uk> <D6050C555CC56940A7AF32652283027601116BF4@mail2.STMIRV01.COM> <4C0E2336.5010003@dallaway.org.uk> <D6050C555CC56940A7AF32652283027602F67CE9@mail2.STMIRV01.COM>
Hi Christophe
Christophe Coutand wrote:
> John Dallaway wrote:
>
>> Is there a reason why you have placed the PHY register definitions
>> into an external header file? Might they be required by other eCos
>> packages?
>>
>> If there _is_ a good reason, then we should add the standard
>> copyright banner to these header files and adhere to eCos file naming
>> conventions. Otherwise, I would suggest placing these definitions in
>> the relevant .c source files directly similar to the support for
>> other PHY parts (INLXT972.c and KSZ8041.c for example).
>
> The reason for having external definitions was to keep all registers
> definition in the same place. Some HW may have to configure special PHY
> registers (to adjust clock delay etc..) to be able to work properly.
> This work is left to the user since it is HW specific.
>
> Currently no package rely on these header files. Let me know what you
> prefer and I can submit a new patch.
OK. I think we should put the header files into the src/ directory for
now and give them names IP101A.h, VSC8244.h and VSC8641.h (matching the
.c source file naming). If they are needed by other packages in the
future, we can easily relocate them to the include/ directory. Can you
also add the standard eCos license/copyright banner at the top of each
header file please?
Thank you
John Dallaway
eCos maintainer