This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: DHCP option parsing bug


On 09/17/2009 05:08 PM, Jay Foster wrote:
The attached patch fixes the DHCP option parsing to deal with DHCP
servers that don't terminate their options with an END tag. The eCos
implementation relies heavily on this. RFC 2132 doesn't specify if this
END tag is required or not. Up until now, I have never seen a DHCP
server do this, but have run into now.

There are other ways to implement this, but I chose this approach as the
least invasive.

How about abstracting the 'recvfrom()+test+repair' sequence to a function, since there are _four_ identical occurrences?

--
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]