Re: eCos uSTL port patch for review

[John Dallaway <john at dallaway dot org dot uk>]

Hi Uwe

John Dallaway wrote:

> uwe.kindler@cetoni.de wrote:
> 
>> here you will find a port of the uSTL library for eCos for
>> review by the eCos maintainers:
>>
>> http://www.cetoni.de/ecos_ustl.zip
> 
> Thank you for the contribution. uSTL looks like a great match for eCos.
> We will, of course, review this and get back to you.

Some initial comments/questions:

a) I would prefer this package to be located under language/cxx/ustl/ to
avoid confusion with the GNU C pre-processor. An easy change.

b) Most of the diff between this package and the master uSTL sources
concerns potentially undefined pre-processor macros. Clearly it's
preferable to modify the original sources as little as possible.
Defining certain macros to "0" in config.h brings its own dangers. Are
the changes you have made to the pre-processor configuration tests
acceptable upstream by the uSTL maintainer(s)?

c) CYGPKG_USTL_TESTS should list the executable names (eg "tests/bvt00")
rather than the source file names for compatibility with the eCos
Configuration Tool.

d) Are you (or anyone else) aware of any compatibility issues arising
from the switch to C99 vsnprintf() behaviour?

e) Does everything behave correctly when built with "-fexceptions -frtti" ?

John Dallaway