This is the mail archive of the mailing list for the eCos project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: SPI lpc2xxx patch

Sergei Gavrikov wrote:
On Tue, Feb 17, 2009 at 12:54:40AM +0000, Jonathan Larmour wrote:

Sergei Gavrikov wrote:


I never try SPI driver for lpc2xxx before, today I did and found an
annoyance copy & paste typo in spi_lpc2xxx_set_config(). Also, to be
ensure the SPI interrupts are using different, was entered a priority
selector, like that was done for the lpc2xxx serial driver.

Thanks for the patch. I've checked it in with some minor mods, primarily placing the new options under the relevant bus options, renaming them consistently with that, and making the bus options components.

I brief check it and got a compile error. There are two undefined CDL
names: cdl_option CYGNUM_IO_SPI_ARM_LPC2XXX_BUS{0,1}_INTPRIO instead
SPI{0,1}. It looks like a copy & paste typo. I prefer no Changelog
this. Fix it, please.

It should have been the other way round to make the option named consistently with its parent. Fixed anyway.

*See us at Embedded World 2009, Nürnberg, Germany, 3-5 Mar, Stand 11-300*
eCosCentric Limited     The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["Si fractum non sit, noli id reficere"]------       Opinions==mine

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]