This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: flashv2 tweaks


> +    cdl_interface CYGHWR_IO_FLASH_DEVICE_NEEDS_CACHE_HANDLED {
> +	display	    "Device driver needs cache handled centrally"
> +	flavor	    booldata
> +	description "
> +            Managing flash often requires interacting with the flash.
> +            Some device drivers do not require the generic flash code to
> +            manipulate the flash, either because they do it themselves or
> +            because the hardware does the right thing. Other drivers
> +            require the generic code to disable/enable the flash before
> +            calling into the driver."
> +    }

I think some of those flash should be cache!

> +    
>      cdl_interface CYGHWR_IO_FLASH_DEVICE_LEGACY {
>          display     "Hardware driver uses the legacy interface"
>          flavor      booldata
>          compile     -library=libextras.a legacy_dev.c
>          description "
>              The generic flash code can work with either a legacy device
>              driver or with V2 drivers. If a legacy driver is used on the
>              current platform then this option will be implemented."
>  	requires    { CYGHWR_IO_FLASH_DEVICE_LEGACY <= 1 }
> +
> +	# For now assume all legacy devices need the cache handled by
> +	# the central code
> +	implements CYGHWR_IO_FLASH_DEVICE_NEEDS_CACHE_HANDLED
>      }

The indentation looks wrong here, or has some tabs crept in?

    Andrew  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]