This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
http://bugzilla.ecoscentric.com/show_bug.cgi?id=1000280 andrew.lunn@ascom.ch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 ------- Additional Comments From andrew.lunn@ascom.ch 2006-05-27 14:15 ------- In hal_arm_mac7100.cdl you have: requires { CYGPKG_IO_SERIAL_DEVICES == 1 } Why? Is this just left over from debugging? Can i remove it? You have the base addresses and interrupts of the serial devices in CDL. This is not normal. They are normally in var_io.h or plf_io.h. What is the reason you did it this way? Please could you add some documentation to flash_security.S. It is not clear what this file does from reading its contents, and seeing words like "backdoor" is not good for a maintainer! The var HAL code should not call mace1 specific functions. How you have debug code in hal_IRQ_handler which does. This code needs removing, or you need to us a generic LED function which all MAC7100 have to implement. In a couple of places i found the name MACE0. How is this related to MACE1? Should all the MACE0 be changed to MACE1? _led_init: Why do you have all the strh commands? If there is a real reason for this a comment would be good. The CDL code contains ROM,RAM & ROMRAM startup types. But you only have ROM linker files etc. Please add the missing files, or remove the unused CDL. I suggest moving the serial port driver header file into /cyg/dev/ser_esci.h Please supply patches to the existing code, not a complete new patch. I've made some changes which i want to keep and using patches makes this possible. -- Configure bugmail: http://bugzilla.ecoscentric.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |