This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix configuration in assert.h.


Sergei Organov wrote:

Well, CYGINT_ISO_EXIT has the default ("data"?) flavor but so are a lot of other CYGINT_xxx even in the same isoinfra.cdl, but CYGINT_ISO_STDIO_FORMATTED_IO as well as many other has "booldata" flavor.

Why the difference? Could somebody please explain, why, for example,

This is one of the (many!) things that I did a long time ago that was meant to have been cleaned up but wasn't. I knew about it, but there was a project deadline, and then I had to move onto other things. You know how it goes. I had got part way through converting them to booldata (initially they were all the default flavor) but timed out. In case you are wondering, this is because Bart implemented "flavor booldata" for interfaces near the end of the project in question.


The answer is that I intended that they should _all_ be booldata, since I want it to behave pretty much like a boolean - the interface can only be on or off, and it's easier and more conventional to use ifdefs rather than ifs for boolean macros - but it can't be "flavor bool" because then you can't present a conflict if there is more than one implementor.

I would be very grateful if you did clean up all the isoinfra options to be booldata. If it was as straightforward as that, of course, it would already have been done. The hassle is then finding out where they are all used and changing those. As a shortcut you may want to do:

grep -r CYGINT_ISO $ECOS_REPOSITORY > /tmp/isoints

and then to search for the users of any individual option, e.g. CYGINT_ISO_EXIT you only have to grep through just /tmp/isoints, which is less painful than the whole repository.

Heck, it may even be easiest to write a script.

Jifl
--
------["The best things in life aren't things."]------      Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]