This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFC 1877 (IPCP Extensions for DNS)

From: Andrew Lunn <andrew at lunn dot ch>
To: Matt Jerdonek <maj1224 at yahoo dot com>
Cc: Andrew Lunn <andrew at lunn dot ch>,Patches eCos <ecos-patches at sources dot redhat dot com>
Date: Mon, 20 Jun 2005 20:41:27 +0200
Subject: Re: RFC 1877 (IPCP Extensions for DNS)
References: <20050612144757.GQ31731@lunn.ch> <20050614153003.50256.qmail@web33512.mail.mud.yahoo.com>

On Tue, Jun 14, 2005 at 08:30:02AM -0700, Matt Jerdonek wrote:
> Andrew,
> 
> Your changes look good.  I tested them out and found a
> few minor issues.
> 1) The #ifdef in sys-ecos.c had a typo that prevented
> it from ever being included.
> 2) Verify the DNS address was non-zero before invoking
> cyg_dns_res_init.
> 3) Pass in the address of the dns_addr[0] rather than
> the value.
> 
> The attached patch has the corrections.  You can diff
> your patch and mine to see exactly what I'm talking
> about.

Thanks

I've committed your changes.

        Andrew

References:
- Re: RFC 1877 (IPCP Extensions for DNS)
  - From: Andrew Lunn
- Re: RFC 1877 (IPCP Extensions for DNS)
  - From: Matt Jerdonek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]