This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: RedBoot: fis free: don't ignore chunk at start.
On Wed, Oct 27, 2004 at 03:08:36PM +0100, David Vrabel wrote:
> Andrew Lunn wrote:
> >Im assuming you don't have redboot at the bottom of flash,
> >but fis free thinks it is in use and so will not list this section.
>
> Yep.
>
> Also. should this option really be:
>
> cdl_option CYGBLD_REDBOOT_MAX_REDBOOT_IMAGE_SIZE {
> display "Maximum size of a RedBoot image"
> flavor data
> default_value { CYGOPT_REDBOOT_FIS_REDBOOT ? 0x20000 : 0 }
> description "
> This option controls the maximum size of the RedBoot image in
> the FIS table."
> }
>
> Since that's all it's used for.
Yes, the discription does seem wrong.
> Regardless, does find_free() really need to explicitly ignore that
> beginning chunk? RedBoot should have a FIS entry and (if my
> understanding of find_free() is right) it will ignore it anyway.
I agree with you here.
So i think your patch is OK. But it seems that code has been
cut/pasted a few times and probably the other ones should be fixed as
well. Please could you submit a patch for them all, and the change to
the documentation attribute of the option.
Thanks
Andrew