This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: CYG_MEMALLOC_FAIL() fix
man, 27.09.2004 kl. 19.53 skrev Andrew Lunn:
> > Index: current/ChangeLog
> > ===================================================================
> > RCS file: /cvs/ecos/ecos/packages/services/memalloc/common/current/ChangeLog,v
> > retrieving revision 1.31
> > diff -w -r1.31 ChangeLog
> > 2a3,7
> > > * No longer invoke cyg_memalloc_alloc_fail() on failure to
> > > resize. It is not an out of memory condition.
>
> Could you explain this better. On first reading of the comment if
> understood it wrongly. Something like
>
> * No longer invoke cyg_memalloc_alloc_fail() on failure to
> resize. It is not an out of memory condition, it just means the current
> memory allocation could not be expanded. realloc() will try allocating
> a completelty new block of memory and only if that fails do we
> have an out of memory condition.
Looks good.
>
> Also your ChangeLog entry looks invalid. It does not appear to start
> with the usual header of date, name, email address. Please also use
> unified diffs, they are much easier for a human to read.
I've currently got two patches in services/memalloc, hence my ChangeLogs
are a bit confused+ I normally use -u, but I forgot this time.
>
> Thanks
> Andrew
--
Øyvind Harboe
http://www.zylin.com