This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
RedBoot flash config CONFIG_ESA default fix
- From: David Vrabel <dvrabel at arcom dot com>
- To: ecos-patches at sources dot redhat dot com
- Date: Tue, 18 Nov 2003 15:19:16 +0000
- Subject: RedBoot flash config CONFIG_ESA default fix
- Organization: Arcom Control Systems Ltd
Hi,
The .dflt field of a RedBoot flash config table entry is too small to
directly hold a default ESA (CONFIG_ESA type). This patch makes .dflt a
pointer to the default ESA.
David Vrabel
--
David Vrabel, Design Engineer
Arcom Tel: +44 (0)1223 411200 ext. 3233
Clifton Road Fax: +44 (0)1223 403400
Cambridge CB1 7EA E-mail: dvrabel@arcom.com
UK Web: http://www.arcom.com/
_____________________________________________________________________
The message in this transmission is sent in confidence for the attention of the addressee only and should not be disclosed to any other party. Unauthorised recipients are requested to preserve this confidentiality. Please advise the sender if the addressee is not resident at the receiving end.
This message has been checked for all viruses by MessageLabs Virus Control Centre.Index: packages/devs/eth/arm/grg/i82559/current/ChangeLog
===================================================================
RCS file: /var/cvs/ecos/packages/devs/eth/arm/grg/i82559/current/ChangeLog,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -B -p -r1.2 -r1.3
--- packages/devs/eth/arm/grg/i82559/current/ChangeLog 30 Sep 2003 12:50:31 -0000 1.2
+++ packages/devs/eth/arm/grg/i82559/current/ChangeLog 18 Nov 2003 14:58:38 -0000 1.3
@@ -1,3 +1,8 @@
+2003-11-18 David Vrabel <dvrabel@arcom.com>
+
+ * include/grg_i82559.inl: The RedBoot flash config default values
+ for ESAs are stored as pointers to the default value.
+
2003-09-30 David Vrabel <dvrabel@arcom.com>
* cdl/grg_i82559_eth_driver.cdl: The Intel GRG and ADI Coyote
Index: packages/devs/eth/arm/grg/i82559/current/include/grg_i82559.inl
===================================================================
RCS file: /var/cvs/ecos/packages/devs/eth/arm/grg/i82559/current/include/grg_i82559.inl,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -B -p -r1.1 -r1.2
--- packages/devs/eth/arm/grg/i82559/current/include/grg_i82559.inl 29 May 2003 10:52:37 -0000 1.1
+++ packages/devs/eth/arm/grg/i82559/current/include/grg_i82559.inl 18 Nov 2003 14:58:38 -0000 1.2
@@ -157,7 +157,7 @@ i82559_sc_array[CYGNUM_DEVS_ETH_INTEL_I8
RedBoot_config_option("Network hardware address [MAC] for eth0",
eth0_esa,
ALWAYS_ENABLED, true,
- CONFIG_ESA, i82559_eth0_priv_data.mac_address
+ CONFIG_ESA, &i82559_eth0_priv_data.mac_address
);
#endif
Index: packages/devs/eth/arm/ixdp425/i82559/current/ChangeLog
===================================================================
RCS file: /var/cvs/ecos/packages/devs/eth/arm/ixdp425/i82559/current/ChangeLog,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -B -p -r1.1 -r1.2
--- packages/devs/eth/arm/ixdp425/i82559/current/ChangeLog 29 May 2003 10:52:37 -0000 1.1
+++ packages/devs/eth/arm/ixdp425/i82559/current/ChangeLog 18 Nov 2003 14:57:59 -0000 1.2
@@ -1,3 +1,8 @@
+2003-11-18 David Vrabel <dvrabel@arcom.com>
+
+ * include/ixdp425_i82559.inl: The RedBoot flash config default values
+ for ESAs are stored as pointers to the default value.
+
2003-03-26 Mark Salter <msalter@redhat.com>
* cdl/ixdp425_i82559_eth_driver.cdl: Default to off for
Index: packages/devs/eth/arm/ixdp425/i82559/current/include/ixdp425_i82559.inl
===================================================================
RCS file: /var/cvs/ecos/packages/devs/eth/arm/ixdp425/i82559/current/include/ixdp425_i82559.inl,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -B -p -r1.1 -r1.2
--- packages/devs/eth/arm/ixdp425/i82559/current/include/ixdp425_i82559.inl 29 May 2003 10:52:37 -0000 1.1
+++ packages/devs/eth/arm/ixdp425/i82559/current/include/ixdp425_i82559.inl 18 Nov 2003 14:57:59 -0000 1.2
@@ -157,7 +157,7 @@ i82559_sc_array[CYGNUM_DEVS_ETH_INTEL_I8
RedBoot_config_option("Network hardware address [MAC] for eth0",
eth0_esa,
ALWAYS_ENABLED, true,
- CONFIG_ESA, i82559_eth0_priv_data.mac_address
+ CONFIG_ESA, &i82559_eth0_priv_data.mac_address
);
#endif
Index: packages/redboot/current/ChangeLog
===================================================================
RCS file: /var/cvs/ecos/packages/redboot/current/ChangeLog,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -B -p -r1.21 -r1.22
--- packages/redboot/current/ChangeLog 1 Oct 2003 08:47:32 -0000 1.21
+++ packages/redboot/current/ChangeLog 18 Nov 2003 15:03:57 -0000 1.22
@@ -1,3 +1,8 @@
+2003-11-18 David Vrabel <dvrabel@arcom.com>
+
+ * src/flash.c (flash_config_insert_value): The default values for
+ ESAs are stored as pointers to the default value.
+
2003-10-01 David Vrabel <dvrabel@arcom.com>
* Various: Remove unnecessary typecasts in calls to init_opts()
Index: packages/redboot/current/src/flash.c
===================================================================
RCS file: /var/cvs/ecos/packages/redboot/current/src/flash.c,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -B -p -r1.13 -r1.14
--- packages/redboot/current/src/flash.c 1 Oct 2003 08:47:32 -0000 1.13
+++ packages/redboot/current/src/flash.c 18 Nov 2003 15:03:57 -0000 1.14
@@ -1995,7 +1995,7 @@ flash_config_insert_value(unsigned char
memcpy(dp, (void *)&opt->dflt, sizeof(in_addr_t));
break;
case CONFIG_ESA:
- memcpy(dp, (void *)&opt->dflt, sizeof(enet_addr_t));
+ memcpy(dp, (void *)opt->dflt, sizeof(enet_addr_t));
break;
#if defined(CYGHWR_NET_DRIVERS) && (CYGHWR_NET_DRIVERS > 1)
case CONFIG_NETPORT: