This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Fix BSD Memory Leak
- From: Andrew Lunn <andrew dot lunn at ascom dot ch>
- To: Nick Garrett <nickg at calivar dot demon dot co dot uk>, Gary Thomas <gary at chez-thomas dot org>
- Cc: "'ecos-patches at sources dot redhat dot com'" <ecos-patches at sources dot redhat dot com>
- Date: Tue, 29 Jul 2003 09:51:00 +0200
- Subject: Re: Fix BSD Memory Leak
- References: <80B97DE95AEED311BA580050047FE98494F64D@mail.systech.com>
Hi Nick, Gary
I was looking at this patch and decide to look back at the original
FreeBSD code to see how they fixed the memory leak. But i've run into
a problem. There is no src/sys/kern/sockio.c in the FreeBSD sources.
Since your names are in the author & contributer sections, please
could you tell me what the history is of this file.
Thanks
Andrew
On Mon, Jul 28, 2003 at 11:04:02AM -0700, Jay Foster wrote:
> The attached patch fixes a memory leak in the BSD stack for eCos. The
> accept() call would leak 48 bytes on each call. The exact number of bytes
> leaked could vary on different platforms, as it depends on the amount of
> roundup done for alignment issues. On my platform ARM7TDMI, it was 32 bytes
> + 16 (for roundup).
>
> I also moved the splx(s) statement into the 'else' case of the conditional
> compile, since it corresponds with the splx() call in the 'if' portion of
> the conditional compile.
>
> Jay Foster
> <<bsd_accept_leak_fix.pat>>