This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: thumb support
>>>>> "Daniel" == Daniel =?iso-8859-1?q?N=E9ri?= <daniel dot neri at sigicom dot com> writes:
Daniel> Bart Veer <bartv at ecoscentric dot com> writes:
>> + ((CYGBLD_ARM_ENABLE_THUMB_INTERWORK || CYGSEM_HAL_ROM_MONITOR) ? "-mthumb-interwork " : "") .
Daniel> Isn't the check for CYGSEM_HAL_ROM_MONITOR redundant?
My patch simply reproduced the original behaviour. I believe
CYGBLD_ARM_ENABLE_THUMB_INTERWORK originally applied to the current
application, i.e. it should be enabled if the application contains a
mixture of ARM and thumb code. ROM monitors like RedBoot are special.
You can build RedBoot in ARM mode, but the eCos application could
still contain thumb code and would interwork with RedBoot via virtual
vectors and traps.
Now, THUMB_INTERWORK already defaults to enabled if you are building
for ROM_MONITOR, i.e. THUMB_INTERWORK is meant to cover both
interworking within an application and between the ROM monitor and the
application. Given that, the check for ROM_MONITOR here would be
redundant and I would have no objection to a patch that removes it.
Bart
--
Bart Veer eCos Configuration Architect
http://www.ecoscentric.com/ The eCos and RedBoot experts