Re: [APPROVE?] Fix spurious interrupt on mpc8xx

[Gary Thomas <gary at mlbassoc dot com>]

On Mon, 2003-03-31 at 07:49, Jonathan Larmour wrote:
> Gary Thomas wrote:
> > On Sun, 2003-03-30 at 23:14, Jonathan Larmour wrote:
> > 
> >>The attached patch fixes a spurious interrupt with asserts enabled when 
> >>using the serial port on viper. It also does some very minor cleanups.
> >>
> >>I haven't checked it in to the trunk, just in case there's some other 
> >>reasoning for the way things was that I've missed (although I doubt it), 
> >>but if it's okay, I would also like approval for the 2.0 branch.
> >>
> > 
> > 
> > I think that these are fine, although the removal of the call to 
> > CPM_reset is a no-op (it should be done by the variant code and
> > then only once, so it has no real effect except for documentation).
> 
> But if someone does CLAIM_COMMS in a RAM loaded app, these channels will 
> then be included, and it will run again, and have side effects on things 
> other than the channels you're using.
> 
> > BTW I've yet to see the spurious interrupt that you are chasing when 
> > using a newer RedBoot (probably even one built from the current branch).
> 
> Yep, was still doing it from the trunk as well as branch as at the end of 
> last week. From what was needed to fix, AFAIK you should just need asserts 
> enabled and to load and run over serial explicitly. The serial TX of 
> talking to GDB is what makes it generate the TX interrupt, which the isr 
> in the driver will (rightly) return 0 for.
> 
> Okay for 2.0 branch explicitly?

Actually, I'm fine with those changes on the trunk as well.  I was 
just bantering about them :-)

-- 
------------------------------------------------------------
Gary Thomas                 |
MLB Associates              |  Consulting for the
+1 (970) 229-1963           |    Embedded world
http://www.mlbassoc.com/    |
email: <gary at mlbassoc dot com>  |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------