This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
RE: KS32C5000 Updates
- From: Jay Foster <jay at systech dot com>
- To: 'Jonathan Larmour' <jifl at eCosCentric dot com>
- Cc: "'ecos-patches at sources dot redhat dot com'" <ecos-patches at sources dot redhat dot com>
- Date: Thu, 27 Mar 2003 09:28:25 -0800
- Subject: RE: KS32C5000 Updates
-----Original Message-----
From: Jonathan Larmour [mailto:jifl at eCosCentric dot com]
Sent: Thursday, March 27, 2003 9:25 AM
To: Jay Foster
Cc: 'ecos-patches at sources dot redhat dot com'
Subject: Re: KS32C5000 Updates
Jay Foster wrote:
> These patches were submitted before, but never applied. Since then,
several
> more patches to the same files have been submitted and applied by Chris
> Garry. I'm resubmitting these patches with Chris Gary's patches merged in
> (attached).
Thanks, that's brilliant. Sorry that things don't get applied in
chronological order :-|.
I've checked over your patch and it looks fine, although I have a query
about the changes to ks32c5000_et_control, specifically
ETH_DRV_GET_IF_STATS etc. specifically why it's needed?
I'm applying your patch anyway though. Obviously I assume you've tested it!
Jifl
Yes, the ETH_DRV_GET_IF_STATS stuff is not really required (the missing
parenthesis for the sizeof() operator seemed odd). I was toying with the
idea of using this, but abandoned it. What was left was the crumbs from
that exercise, and it seemed harmless anyway.
I tested it with the LXT970 and ICS1893AF PHYs. Currently, the ICS1893AF
PHY uses the same configuration as the ICS1890 PHY. I am still testing the
ICS1893AF PHY, so this could change, but that would be a separate patch
(against the PHY code).
Jay