This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
RE: unsuitable default value for option
- From: "Koeller, T." <Thomas dot Koeller at baslerweb dot com>
- To: 'Andrew Lunn' <andrew dot lunn at ascom dot ch>
- Cc: "ecos-patches (E-Mail)" <ecos-patches at sources dot redhat dot com>
- Date: Tue, 25 Mar 2003 16:54:13 +0100
- Subject: RE: unsuitable default value for option
Admitted, but why would I prefer 0x100000 over any other value?
The entire flash may not even be that large. It would be better
then to provide no default at all.
tk
> -----Original Message-----
> From: Andrew Lunn [mailto:andrew dot lunn at ascom dot ch]
> Sent: Tuesday, March 25, 2003 4:49 PM
> To: Koeller, T.
> Cc: ecos-patches (E-Mail)
> Subject: Re: unsuitable default value for option
>
>
> On Tue, Mar 25, 2003 at 04:42:12PM +0100, Koeller, T. wrote:
> > Hi,
> >
> > the default value for CYGNUM_IO_FLASH_BLOCK_OFFSET_1 in
> > io/flash/current/cdl/io_flash.cdl (0x100000) is not really
> > appropriate. Better set it to zero.
>
> Doesn't this lead to the case that someone could accidentally change
> there boot block by not configuring this option? It seems to me
> 0x100000 is safer.
>
> Andrew
>
> >
> > tk
> >
> > diff -ru io_orig/flash/current/ChangeLog io/flash/current/ChangeLog
> > --- io_orig/flash/current/ChangeLog Tue Mar 25 16:34:02 2003
> > +++ io/flash/current/ChangeLog Tue Mar 25 16:37:35 2003
> > @@ -1,3 +1,8 @@
> > +2003-03-25 Thomas Koeller <thomas dot koeller at baslerweb dot com>
> > +
> > + * cdl/io_flash.cdl: Changed default value for
> > + CYGNUM_IO_FLASH_BLOCK_OFFSET_1 to 0x0.
> > +
> > 2003-03-19 Thomas Koeller <thomas dot koeller at baslerweb dot com>
> >
> > * src/flashiodev.c: Fixed trivial error.
> > diff -ru io_orig/flash/current/cdl/io_flash.cdl
> > io/flash/current/cdl/io_flash.cdl
> > --- io_orig/flash/current/cdl/io_flash.cdl Tue Mar 25 16:34:02 2003
> > +++ io/flash/current/cdl/io_flash.cdl Tue Mar 25 16:35:27 2003
> > @@ -153,12 +153,12 @@
> > cdl_option
> CYGNUM_IO_FLASH_BLOCK_OFFSET_1 {
> > display "Start
> offset from
> > flash base"
> > flavor data
> > - default_value 0x100000
> > + default_value 0x0
> > description "
> > This gives the
> offset from
> > the base of flash which this
> > block device corresponds
> > to."
> > }
> > - cdl_option
> > CYGNUM_IO_FLASH_BLOCK_LENGTH_1 {
> > + cdl_option
> CYGNUM_IO_FLASH_BLOCK_LENGTH_1 {
> > display "Length"
> > flavor data
> > default_value 0x100000
> >
> >
> > -----------------------------------------------
> > Thomas Koeller, Software Development
> >
> > Basler Vision Technologies
> > An der Strusbek 60-62
> > 22926 Ahrensburg
> > Germany
> >
> > Tel +49 (4102) 463-390
> > Fax +49 (4102) 463-46390
> >
> > mailto:Thomas dot Koeller at baslerweb dot com
> > http://www.baslerweb.com
> >
> >
>