Re: New eCos architecture port: OpenRISC processor

[Jonathan Larmour <jifl at eCosCentric dot com>]

Scott Furman wrote:
> > -----Original Message-----
> > Thanks! With the 2.0 beta I'm a little busy to apply it just at the
>
> moment
>
> > - there are a few pedantic issues like missing ChangeLog files,
>
> inaccurate
>
> > DESCRIPTION headers at the tops of files and so on, but I've yet to do
>
> a
>
> > detailed review.
>
>
> I'm happy to make whatever changes are necessary.
>
> I've found two files where the headers didn't match the contents:
> hal_diag.c and openrisc_orp_flash.c.  Please let me know if you spot any
> others.

Will do, or it may just be quicker to update them when I see them.

> > Perhaps it may also be good to have a README.txt in an appropriate doc
> > subdirectory of one or both of the pacakges listing the issues like
>
> you
>
> > mentioned in the mail?
>
>
> Maybe I should just create one doc subdir in packages/hal/openrisc/,
> rather than have redundant ones in the platform package and the
> architecture package ?

Ah, no, the way eCos is designed, it has to go under the version 
subdirectory, which for CVS is current. Later on, probably in eCos 2.1, 
eCos will change to a properly package-oriented system where individual 
packages are downloaded.

So in a doc directory instead one or both of the HAL packages really is 
better.

> Where should I put my shell script to build the host toolchain ?  Should
> I create a packages/hal/openrisc/host subdir and put the script in it or
> do you think I should put the script in the doc subdir also ?

That's probably "doc" in the arch HAL actually since one could argue it's 
information that accompanies the README.txt.

> I'll add an (almost empty) Changelog file as well.

Oh sure. As long as it has your name, the licence, an entry inside it 
saying "* New package" or something, and also if you like an attribution 
to the company that contributed the port, that should be enough.

> I can send you an updated zip package with these changes whenever you
> want.

Whenever you are happy with it.

Jifl
--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine