This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: i82559 on ebsa patch
Andrew Lunn wrote:
On Fri, Oct 18, 2002 at 04:25:41AM +0100, Jonathan Larmour wrote:
And since I can't work it out, why is DEMUX_ALL no longer needed?
It gave me a headache trying to work this out and im not sure i can
remember correctly. DEMUX_ALL and MUX_INTERRUPTS are mutually
exclusive.
<Hugo>Oh yeah!</Hugo> There's a #error check for that even.
Presumably the distinction is as described in the comment for DEMUX_ALL:
// others. In this circumstance it is permitted for
// cyg_pci_translate_interrupt [HAL_PCI_TRANSLATE_INTERRUPT]
// to return invalid for 2nd and subsequent devices.
> If you have one device, its still on
CYGNUM_HAL_INTERRUPT_PCI_IRQ so you still need MUX_INTERRUPTS.
Hmm I'd have thought that that's ok since it will just attach the normal
eth_isr and everything will work fine with only one device. It should
still have recognised PCI_IRQ as the correct vector in the PCI scan surely?
For testing i actually did disable one of the devices by CDL, since i
only have a DHCP server on one of them and was too impatient for
init_all_network_interfaces() to timeout and fail on the other before
running the net tests.
If you have actually tested that config, then I'm not so bothered -
DEMUX_ALL can't be required if it recognised the second device. I'm just
thinking now that there might be redundant code in use for one device.
Jifl
--
eCosCentric http://www.eCosCentric.com/ <info@eCosCentric.com>
--[ "You can complain because roses have thorns, or you ]--
--[ can rejoice because thorns have roses." -Lincoln ]-- Opinions==mine